Skip to content

[Intel GPU] Extend TestQAT module with xpu testcases #3177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Intel GPU] Extend TestQAT module with xpu testcases #3177

wants to merge 1 commit into from

Conversation

@agrabow
Copy link
Contributor

@agrabow agrabow commented Oct 15, 2025

Add xpu mode to tests from test_qat.py TestQAT module

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3177

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 15, 2025
@lahead
Copy link

lahead commented Oct 24, 2025

@liangan1 please review

@liangan1 liangan1 self-requested a review October 26, 2025 23:11
liangan1
liangan1 reviewed Oct 26, 2025
View reviewed changes
test/quantization/test_qat.py Outdated
SEED = 123
GPU_DEVICES = (["cuda"] if torch.cuda.is_available() else []) + (
["xpu"] if torch.xpu.is_available() else []
)
Copy link
Collaborator

@liangan1 liangan1 Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CUDA and XPU is exclusive in a torch whl which means that it should not be a list. Besides, the GPU_DEVICES also involve a lot of changes in the following PRs. Suggest to use DEVICE directly.

@liangan1 liangan1 added topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) xpu Intel XPU related features ciflow/xpu label used to trigger xpu CI jobs labels Oct 26, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 26, 2025

To add the ciflow label ciflow/xpu please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/xpu label used to trigger xpu CI jobs label Oct 26, 2025
@liangan1 liangan1 added the ciflow/xpu label used to trigger xpu CI jobs label Nov 4, 2025
@pytorch-bot pytorch-bot bot removed the ciflow/xpu label used to trigger xpu CI jobs label Nov 4, 2025
@liangan1
Copy link
Collaborator

liangan1 commented Nov 6, 2025 •
edited
Loading

This PR should depends on PR # PR##3249 to be triggered by "ciflow/xpu"

@liangan1 liangan1 mentioned this pull request Nov 18, 2025
Open
16 tasks
liangan1
liangan1 reviewed Nov 18, 2025
View reviewed changes
test/quantization/test_qat.py
if torch.accelerator.is_available()
else None
)

Copy link
Collaborator

@liangan1 liangan1 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls use the utils func defined in #3335.

@liangan1 liangan1 added the ciflow/xpu label used to trigger xpu CI jobs label Nov 18, 2025
@liangan1 liangan1 mentioned this pull request Nov 18, 2025
Open
@pytorch-bot pytorch-bot bot removed the ciflow/xpu label used to trigger xpu CI jobs label Nov 20, 2025
@agrabow agrabow force-pushed the xpu_test_qat branch 2 times, most recently from d413980 to 5d86dd0 Compare November 20, 2025 16:08
@liangan1 liangan1 added the ciflow/xpu label used to trigger xpu CI jobs label Nov 21, 2025
@liangan1
Copy link
Collaborator

liangan1 commented Nov 21, 2025

@pytorchbot rebase

@liangan1
Copy link
Collaborator

liangan1 commented Nov 21, 2025

@agrabow pls rebase your code.

@agrabow
[Intel GPU] Extend TestQAT module with xpu testcases
a8d6d03 
Add xpu mode to tests from test_qat.py TestQAT module
@pytorch-bot pytorch-bot bot removed the ciflow/xpu label used to trigger xpu CI jobs label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

@liangan1 liangan1 liangan1 approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) xpu Intel XPU related features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@agrabow @lahead @liangan1 @jerryzh168